Added check for cfg_cu payload_size to be within MAX_CQ_SLOT_SIZE. #7630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed xgq assignment issue for multislot Signed-off-by: Saif <saifuddi@amd.com> * Fixed allignment issues Signed-off-by: Saifuddin <saifuddi@xilinx.com> * Cleanup memory manager for built in ps kernel support Signed-off-by: Saifuddin <saifuddi@xilinx.com> * Get the ps kernel mem info from zocl through xgq * Fix issue to Get the ps kernel mem info from zocl through xgq Signed-off-by: Saifuddin <saifuddi@xilinx.com> * Not to fail the driver is PS kernel memory is not configured * Fixed review comments Signed-off-by: Saifuddin <saifuddi@xilinx.com> * Added memory management changes to this branch Signed-off-by: Saifuddin <saifuddi@xilinx.com> * Delete unused variable Signed-off-by: Saifuddin <saifuddi@xilinx.com> * Fixed one issue Signed-off-by: Saifuddin <saifuddi@xilinx.com> * Remove the multislot fix from PS memory fix branch Signed-off-by: Saifuddin <saifuddi@xilinx.com> --------- Signed-off-by: Saif <saifuddi@amd.com> Signed-off-by: Saifuddin <saifuddi@xilinx.com> Co-authored-by: Saif <saifuddi@amd.com> (cherry picked from commit 47b38ea)
…xocl_kds.c (Xilinx#7552) * Added check for cfg_cu payload_size to be within MAX_CQ_SLOT_SIZE Signed-off-by: Jeff Lin <jeffylin@xilinx.com> * Added additional check for payload_size if it exceeds MAX_CQ_SLOT_SIZE before doubling and error out if it is exceeded. Signed-off-by: Jeff Lin <jeffylin@xilinx.com> --------- Signed-off-by: Jeff Lin <jeffylin@xilinx.com> Co-authored-by: Jeff Lin <jeffylin@xilinx.com>
saifuddin-xilinx
requested changes
Jul 18, 2023
| @@ -1955,6 +1955,10 @@ xocl_kds_xgq_cfg_cus(struct xocl_dev *xdev, xuid_t *xclbin_id, struct xrt_cu_inf | |||
| * approach. | |||
| */ | |||
| cfg_cu->payload_size = cfg_cu->payload_size * 2; | |||
| if(cfg_cu->payload_size > MAX_CQ_SLOT_SIZE) { | |||
There was a problem hiding this comment.
if (cfg_cu->payload_size > MAX_CQ_SLOT_SIZE) {
|
Build failed :( |
|
retest this please |
|
Build failed :( |
|
There is already a PR for this #7577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
If the cfg_cu payload size is more than expected after doubling, then making sure it should be within MAX_CQ_SLOT_SIZE.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Issue was intorduced by the CR-1162158
How problem was solved, alternative solutions (if any) and why they were rejected
Cherry-picked from the commit: 4e2b68f
Risks (if any) associated the changes in the commit
No
What has been tested and how, request additional testing if necessary
Tested on V70.
Documentation impact (if any)
No