Templatize internal utility aligned_alloc #7641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make aligned alloc return managed ptr of specified type. Preserve existing usage of default void and exposed deleter, but hide the deleter for specified types. Feels like this could be more elegant with better use of C++ features. Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>
maxzhen
approved these changes
Jul 25, 2023
Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>
|
Build failed :( |
|
retest this please. |
|
Build Passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Make aligned alloc return managed ptr of specified type.
How problem was solved, alternative solutions (if any) and why they were rejected
Preserve existing usage of default void and exposed deleter, but hide the deleter for specified types.
Feels like this could be more elegant with better use of C++ features.