Zocl refactoring : Initial version #7645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saifuddin <saifuddi@xilinx.com>
Signed-off-by: Saifuddin <saifuddi@xilinx.com>
Signed-off-by: Saifuddin <saifuddi@xilinx.com>
Signed-off-by: Saifuddin <saifuddi@xilinx.com>
saifuddin-xilinx
requested review from
chvamshi-xilinx and
mamin506
as code owners
saifuddin-xilinx
changed the title
|
Build failed :( |
|
retest this please |
|
Build failed :( |
|
retest this please. |
|
Build failed :( |
|
retest this please. |
|
Build Passed! |
mamin506
approved these changes
Aug 1, 2023
jeffli-xilinx
approved these changes
Aug 1, 2023
chvamshi-xilinx
approved these changes
Aug 3, 2023
maxzhen
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This PR is targeting for ZOCL refactoring. This has the following changes:
1. Files are separated out in three directory. i.e. common, zert, edge
2. Code related to hybrid device are moved under zert directory
3. Code related to legacy edge device are moved under edge directory
4. Common codes are placed under common directory
No functionality level of code changes for this PR. Some files are divided based on the type of device it supports.
Tested this for both V70 and vck190 device for both types of device.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)