CR-1170195: Fixing issue with seg fault in AIE status/profiling/trace #7654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Processing the system_metadata section in profiling was crashing on designs that had PL kernels and AIE kernels. This was because newly introduced code was based on the faulty assumption that only PL kernels and compute units were listed in the specific system_metadata sections that PL profiling was dependent on. On designs that have AIE kernels in addition to PL kernels, we were going outside the bounds of our internal array.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
This bug was introduced in pull request 7640 and it was discovered with testing on AIE designs.
How problem was solved, alternative solutions (if any) and why they were rejected
This pull request no longer accesses the problematic array, but instead creates a local map of compute unit ID to compute unit name based solely on the information in the system_metadata section.
Risks (if any) associated the changes in the commit
Low risk as this fixes the seg fault and still maintains the functionality, but is dependent on the system metadata section format.
What has been tested and how, request additional testing if necessary
This has been tested on a mixed AIE + PL design on vek280 and a PL only design on the u200.
Documentation impact (if any)
No documentation impact.