Force xclbin won't impact if current xclbin in use #7658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>
Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>
|
Build failed :( |
|
retest this please |
|
Build failed :( |
|
Build Passed! |
chvamshi-xilinx
approved these changes
Aug 10, 2023
maxzhen
approved these changes
Aug 10, 2023
saifuddin-xilinx
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
CR-1166962 When force xclbin is enabled when hw_ctx is open we are getting " Failed to create hardware context". This is becauseit's trying to download the xclbin again even the current bitstream is locked.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Checking the bitstram is locked or not when force xclbin is trying to redownload the xclbin again.
How problem was solved, alternative solutions (if any) and why they were rejected
Added one more check in the xocl_resolver function to check if bitstream is locked or not.
Risks (if any) associated the changes in the commit
No
What has been tested and how, request additional testing if necessary
Tested on u250.
Documentation impact (if any)
NA