Added hw ctx support for edge #8305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bisingha-xilinx
requested review from
rozumx,
stsoe,
larry9523,
chvamshi-xilinx and
mamin506
as code owners
bisingha-xilinx
force-pushed
the
add_hw_ctx
branch
from
fc97f9e
to
f0c9167
Compare
|
@bisingha-xilinx , Overall changes is looking good.
|
|
Hi @bisingha-xilinx , Added "do not merge " tag. Please confirm whether things are working or not. You can remove this tag once everything works fine. |
bisingha-xilinx
force-pushed
the
add_hw_ctx
branch
from
f0c9167
to
6fa1846
Compare
bisingha-xilinx
force-pushed
the
add_hw_ctx
branch
from
6fa1846
to
a84a065
Compare
Hi @chvamshi-xilinx yes, I verified all the tests, and all are passing. here is the table with status:
|
Hi, @chvamshi-xilinx removed the tag as things are working fine with latest changes. |
chvamshi-xilinx
approved these changes
Aug 26, 2024
saifuddin-xilinx
requested changes
Aug 26, 2024
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
bisingha-xilinx
force-pushed
the
add_hw_ctx
branch
from
a84a065
to
f377c58
Compare
saifuddin-xilinx
approved these changes
Aug 26, 2024
vipangul
pushed a commit
to vipangul/XRT
that referenced
this pull request
Sep 11, 2024
* Registering the xclbin without loading it Signed-off-by: bisingha <bikash.singha@amd.com> * Added ioctl framework for create/destroy hw context for edge Signed-off-by: bisingha <bikash.singha@amd.com> * Added initial commit to create/destroy hw context Signed-off-by: bisingha <bikash.singha@amd.com> * Added open/close graph hw context calls Signed-off-by: bisingha <bikash.singha@amd.com> * Added graph open/close context Signed-off-by: bisingha <bikash.singha@amd.com> * Adjusted previous commits Signed-off-by: bisingha <bikash.singha@amd.com> * Adjusted previous commits Signed-off-by: bisingha <bikash.singha@amd.com> * Removed slot_id hardcoding for create/destroy hw_ctx Signed-off-by: bisingha <bikash.singha@amd.com> * Removed unnecessary function calls Signed-off-by: bisingha <bikash.singha@amd.com> * Added slot_id check Signed-off-by: bisingha <bikash.singha@amd.com> * Added cu open/close context support Signed-off-by: bisingha <bikash.singha@amd.com> * Added execbuf support with hw context Signed-off-by: bisingha <bikash.singha@amd.com> * Adjusted previous commits Signed-off-by: bisingha <bikash.singha@amd.com> --------- Signed-off-by: bisingha <bikash.singha@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
create/destroy hw_context enablement for edge
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Fixed issues: register xclbin support, hw ctx support
How problem was solved, alternative solutions (if any) and why they were rejected
Programming the xclbin while creating the hw ctx and added zocl driver support for create/destroy hw_context
Risks (if any) associated the changes in the commit
n/a
What has been tested and how, request additional testing if necessary
Please find the table below. Tested on hw emu with vck190 xpfm with 2024.2 TA
Documentation impact (if any)
Please note: by default, hw context is enabled on the edge shim. hw_context=false has to be provided on xrt.ini if someone wants to go with the legacy (non hwctx) flow.