Export functions from module_int.h to use in shim tests #8398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bramandlapalli <rbramand@amd.com>
stsoe
approved these changes
Sep 6, 2024
chvamshi-xilinx
approved these changes
Sep 6, 2024
vipangul
pushed a commit
to vipangul/XRT
that referenced
this pull request
Sep 11, 2024
Signed-off-by: Bramandlapalli <rbramand@amd.com> Co-authored-by: Bramandlapalli <rbramand@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
shim tests in xdna driver uses functions from module_int.h, these tests were earlier used in linux flow and now being ported to windows and windows needs functions to be exported to be used in application that imports them. so making this change
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Discovered in local testing when trying using windows
How problem was solved, alternative solutions (if any) and why they were rejected
Added macro for required functions
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
Tested by building application in windows
Documentation impact (if any)
NA