Use 64 bit timestamps in ML Timeline Record timer data #8416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ishita Ghosh <ishita.ghosh@amd.com>
jvillarre
approved these changes
Sep 13, 2024
|
@stsoe Thanks for merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
ML Timeline Record Timer was using 32 bit timestamps. But large long running design can overflow 32 bit timer, so we need to use 64bit timestamps. This also helps match with AIE Event trace 64bit timestamped data.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Large long running designs showed overflow in 32 bit timer
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Long running designs with and without AIE Event trace
Documentation impact (if any)