Enhance no-op test logics #8423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AShivangi <shivangiagarwal53@gmail.com>
maxzhen
approved these changes
Sep 16, 2024
|
@rchane is testing it out on linux to make sure there's no regression. Will update the PR accordingly |
|
birman29 wasn't giving correct numbers, but Max tested it out on his Strix/linux and it works as expected. This PR is ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Creating run objects inside the loop that is being timed increases the latency by 1-2 us
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Developer testing by Max
How problem was solved, alternative solutions (if any) and why they were rejected
latency: I create an object and before starting the timer and call start/wait inside the loop
throughput: I enqueue 9 objects and as soon as an object finishes, I enqueue another object
Risks (if any) associated the changes in the commit
N/A
What has been tested and how, request additional testing if necessary
Tested on stx/mcdm
Documentation impact (if any)
N/A