correction n W1 type and loading loops + a helper function for saving fixed_point data #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added helper function. And fixed the inner loops for W1 and its type.
|
Hi @arkhodamoradi, the regression fails when executing the |
|
Yes, I left the W1 type as ap_fixed but the gen_weight.py was not adjusted. I changed the W1 type to ap_uint and the unit test is successful. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The W1 type should be either ap_int<WIDTH> or ap_fixed<WIDTH, _I>.
The PE loop for loading W1 should be moved to outside.
The helper function can be used or discarded :)