Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system version of opt and llvm-link #116

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

dotkrnl
Copy link
Contributor

@dotkrnl dotkrnl commented Jun 27, 2022

This PR prefers the system (or, PATH) version of opt and llvm-link, when installed or built, to the Vitis version. This PR also fixes issues raised by Jinming and Andra. When the Vitis environment is set up, the Vitis version of llvm-link will be used, which leads to errors.

Copy link
Collaborator

@stephenneuendorffer stephenneuendorffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the more correct thing be to avoid modifying the PATH entirely?

@dotkrnl
Copy link
Contributor Author

dotkrnl commented Jun 28, 2022

Would the more correct thing be to avoid modifying the PATH entirely?

Definitely. I am not very familiar with the PATH requirements of aietools yet so this might be a quick fix for now. Maybe an issue can be created for removing PATH changes.

@lau-amd lau-amd merged commit 6c954b3 into Xilinx:main Jun 28, 2022
dotkrnl pushed a commit to heterosys/mlir-aie that referenced this pull request Jun 28, 2022
fifield pushed a commit to fifield/mlir-aie that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants