Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XRTBackend API Cleanup #634

Merged
merged 5 commits into from
Jul 1, 2024
Merged

XRTBackend API Cleanup #634

merged 5 commits into from
Jul 1, 2024

Conversation

hunhoffe
Copy link
Collaborator

@hunhoffe hunhoffe commented Jul 1, 2024 •
edited
Loading

There are a few things about the XRTBackend that are a bit unintuitive:

  • You can't actually set the insts file path (unused parameters)
  • There are unneeded parameters (module in load())
  • There aren't safety checks for the state that is saved in the backend during load()

This PR cleans up a few aspects of XRTBackend to ensure parameters make sense and are used as one would expect.

@hunhoffe hunhoffe marked this pull request as ready for review July 1, 2024 19:37
@hunhoffe hunhoffe mentioned this pull request Jul 1, 2024
Closed
@fifield fifield self-requested a review July 1, 2024 22:28
fifield
fifield approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@fifield fifield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@hunhoffe hunhoffe merged commit 45a1152 into main Jul 1, 2024
11 checks passed
@hunhoffe hunhoffe deleted the xrt-air-backend branch July 1, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifield fifield fifield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hunhoffe @fifield