Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test V2F and V3F associated Abs and AbsInPlace functions #37

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Test V2F and V3F associated Abs and AbsInPlace functions #37

merged 2 commits into from
Oct 5, 2023

Conversation

gray-adeyi
Copy link
Contributor

@gray-adeyi gray-adeyi commented Oct 5, 2023 •
edited by Xkonti
Loading

I was looking to implement IsZero yesterday but my knowledge on vectors is bad. It has been implemented already, so I decided to write a test instead

Related: #34

Xkonti
Xkonti approved these changes Oct 5, 2023
View reviewed changes
Copy link
Owner

@Xkonti Xkonti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great 👍

@Xkonti Xkonti merged commit e0bae7a into Xkonti:main Oct 5, 2023
@gray-adeyi
Copy link
Contributor Author

gray-adeyi commented Oct 5, 2023 •
edited
Loading

Doesn't count for hacktoberfest? I can't find any hacoberfest and hacktoberfest-accepted label

@Xkonti
Copy link
Owner

Xkonti commented Oct 5, 2023

Hopefully that works :)

@gray-adeyi
Copy link
Contributor Author

Thanks.

@Xkonti Xkonti mentioned this pull request Oct 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xkonti Xkonti Xkonti approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gray-adeyi @Xkonti