Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup + fixes for Windows ISOs + memory-only supported #1

Closed
wants to merge 6 commits into from

Conversation

saidelike
Copy link

No description provided.

Copy link
Owner

@Xmister Xmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have some minor nitpicking comments if you don't mind.

README.md Show resolved Hide resolved
isoinfo/isoinfo.go Show resolved Hide resolved
udf.go Show resolved Hide resolved
@Xmister
Copy link
Owner

Xmister commented Jan 16, 2021

Addressing in #2

@Xmister Xmister closed this Jan 16, 2021
@saidelike
Copy link
Author

Thanks for merging and fixing the minor discussed points. Also makes sense not to merge the Show() functions I guess!

@Xmister
Copy link
Owner

Xmister commented Jan 18, 2021

@saidelike The main reason for skipping Show() functions is that I'm using this lib in an app where app size can be an issue. If there is no strong reason for me to include heavy packages like fmt, I tend not to.

Also, thank you for the PR! :) Having more versatile compatibility is always welcome.

@saidelike
Copy link
Author

@saidelike The main reason for skipping Show() functions is that I'm using this lib in an app where app size can be an issue. If there is no strong reason for me to include heavy packages like fmt, I tend not to.

Also, thank you for the PR! :) Having more versatile compatibility is always welcome.

Gotcha, makes total sense! I wonder if we could have "ifdef" C-style in golang to allow enabling these when we need them such as adding new features or debugging problems such as when I did... but that is another story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants