Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a control command to set environment variable used to start new processes #3502

Closed
normanr opened this issue Mar 25, 2022 · 5 comments
Closed
Labels
enhancement New feature or request server

Comments

@normanr
Copy link

normanr commented Mar 25, 2022

Is your feature request related to a problem? Please describe.
I'm always frustrated when I forget to set an environment variable before starting the xpra server, because all programs that I start run without the environment variable until I restart the xpra server (a simple examples is changing SSH_AUTH_SOCK after restarting ssh-agent).

Describe the solution you'd like
I'd like to be able to set the environment variables used for starting new applications via xpra control after I've started xpra.

Describe alternatives you've considered
I can just restart xpra, it's a pain. gnu screen allows me to run :setenv, so why shouldn't xpra allow something similar.

@normanr normanr added the enhancement New feature or request label Mar 25, 2022
@totaam totaam added the server label Mar 25, 2022
@totaam
Copy link
Collaborator

totaam commented Mar 25, 2022

Was already on my TODO list. Even better to have a ticket for it.

@totaam
Copy link
Collaborator

totaam commented Mar 25, 2022

@normanr Done, here are some examples:

xpra info :10 | grep start-env
xpra control :10 start-env unset GTK_CSD
xpra control :10 start-env set GTK_CSD 1
xpra info :10 | grep start-env.GTK_CSD

@totaam totaam closed this as completed Mar 25, 2022
@normanr
Copy link
Author

normanr commented Mar 30, 2022

👍

I found a workaround, which was to export the variables I want and then run xpra upgrade. It works well enough, even though it's kinda ugly (and causes your xpra connection to drop), at least it doesn't restart the X server.

@totaam
Copy link
Collaborator

totaam commented Mar 31, 2022

@normanr when you xpra upgrade, the client should notice and automatically re-connect.

@normanr
Copy link
Author

normanr commented Mar 31, 2022

Manually reconnecting isn't a big issue. Also I have automatic reconnect disabled, because establishing the connection requires me to be present to confirm use of my ssh key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server
Projects
None yet
Development

No branches or pull requests

2 participants