deps: bump reqwest, chrone, rust-ini #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlyon
force-pushed
the
main
branch
2 times, most recently
from
1254a29
to
26d3660
Compare
|
This is now ready for review. The last commit is optional and just flattens the tests rather than running them in a loop which helps with clarity if a subset of them fail. You can see the result of the flattening in CI: https://github.com/Xuanwo/reqsign/actions/runs/8389509909/job/22975874669?pr=430#step:4:583 each test is named with the name of the test and then the name of the |
arlyon
force-pushed
the
main
branch
2 times, most recently
from
f821817
to
f5fe06c
Compare
Note, this just mirrors the behavior from the original (deprecated) function by panicing in the same way.
Xuanwo
reviewed
Mar 22, 2024
Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps reqwest (and by extension the rest of the hyper / http ecosustem to 1.0).
Note that I have also moved construction of the request out of the signing benchmark since the new API requires that we convert all the headers to strings which impacts the results. So now the bench is only the actual signing itself plus a clone of the processed headers.