Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace version.ts by package.json #102

Closed
johannesheucher-gip opened this issue Dec 14, 2023 · 1 comment · Fixed by #103
Closed

Replace version.ts by package.json #102

johannesheucher-gip opened this issue Dec 14, 2023 · 1 comment · Fixed by #103
Assignees
@johannesheucher-gip

Comments

@johannesheucher-gip
Copy link
Contributor

johannesheucher-gip commented Dec 14, 2023 •
edited
Loading

The version.ts file is not needed, anymore because all its information can be found inside package.json.
Use the version string from the package.json to show inside the title bar.
@johannesheucher-gip johannesheucher-gip self-assigned this Dec 14, 2023
@johannesheucher-gip johannesheucher-gip mentioned this issue Dec 14, 2023
Closed
johannesheucher-gip added a commit that referenced this issue Dec 14, 2023
@johannesheucher-gip
removed version.ts (#102)
5c5aa72 
which has been replaced by package.json
@johannesheucher-gip johannesheucher-gip linked a pull request Dec 14, 2023 that will close this issue
removed version.ts (#102) #103
Merged
johannesheucher-gip added a commit that referenced this issue Dec 14, 2023
@johannesheucher-gip
removed version.ts (#102) (#103)
9a0ea0a 
which has been replaced by package.json
@PatrickVonMassow-GIP
Copy link
Contributor

Warning: After this change, projects using Zeta only work when compiler option resolveJsonModule is enabled in tsconfig.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johannesheucher-gip johannesheucher-gip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed version.ts (#102) Xyna-Factory/xyna-zeta
2 participants
@johannesheucher-gip @PatrickVonMassow-GIP