#57 für den DHICB-9105 Datenschutzhinweis die Zeta Komponente Login m… #77

rojansen · 2023-10-18T08:30:54Z

Die Änderungen an der lokalen ZetaBibliothek aus dem NFRD Projekt wurden in die Zeta Bibliothek übernommen. Es wurde nicht getetstet ob sich der Code bauen und komplilieren lässt

…it einen Button ergänzt

johannesheucher-gip · 2023-10-18T10:59:49Z

auth/login/auth-login.component.ts

@@ -88,6 +91,7 @@ export class AuthLoginComponent {
        private readonly dialogService: XcDialogService,
        private readonly i18n: I18nService
    ) {
+        this.local_i18n = i18n;


you already have a local instance of the I18nService through dependency injection. Use with this.i18n.

IntelliJ marks a mistake when i directly use this.i18n.
Is it possible that i18n is only accessible in the constructor?

As long as you declare private readonly i18n: I18nService as a constructor parameter, the i18n will be handled as a private member of your class. Maybe IntelliJ is misconfigured for this case?

i found the problem
in the netFactoryComponent.ts
the constructor looks like this
constructor( i18n: I18nService
and not like this
constructor(private readonly i18n: I18nService
and i assume that is the same in the aut login but it isnt

johannesheucher-gip · 2023-10-18T11:02:27Z

auth/login/auth-login.component.ts

@@ -74,6 +74,9 @@ export class AuthLoginComponent {
        }
    };

+    showPrivacyButton = !!environment.zeta.privacyLink;
+    local_i18n :I18nService;


syntax convention would be local_i18n: I18nService;
But you don't need that member, see below.

johannesheucher-gip · 2023-10-18T12:01:44Z

auth/login/auth-login.component.ts

@@ -127,6 +131,20 @@ export class AuthLoginComponent {
        }
    }

+    openPrivacyLink() {
+        switch(this.local_i18n.language){


with the switch, you have to adjust this block for each additional language.
And each project using this feature would have to apply to the convention to only have a lang-parameter for "en" and not for "de", for example. Will be problematic for a non-german company.

I would rather like sth. as
window.open(environment.zeta.privacyLink + '&lang=' + this.i18n.language, '_blank').focus();.

Another, more flexible option is to place a privacyLink: function(lang: string): string into the environment instead of only the string itself

this solution doesn't work because this.i18n.language =en-US but the &lang Parameter needs only en
but i added like you suggest a function in the enviroment.ts
so for other companys they extend the switch statement only in the enviroment.ts.
i think the switch statement is neccessary because the this.i18n.languag Parameter and the &lang Parameter doesn t match
and telekom have only links for language german and english

…ask-2' into 57-add-privacy-button-to-login-mask-2

…ung wieder eingefügt

johannesheucher-gip · 2023-10-19T17:28:33Z

api/zeta-environment.interfaces.ts

+    /**
+     * if the link is set, then the privacy button will be displayed inside the login mask
+     */
+    privacyLink?: string;


now you won't need this one, anymore, as it would be redundant to the getPrivacyLink function. Only use the above one and merge the respective documentation.

to delete this was my first try, but i run into a problem with this function showPrivacyButton = !!environment.zeta.privacyLink; Iexplain more in a mail

johannesheucher-gip · 2023-10-19T17:29:04Z

api/zeta-environment.interfaces.ts

+    /**
+     * extend the Privacy Link with the language parameter
+     */
+    getPrivacyLink?(lang: string): string;


great! This is what I was expecting.

johannesheucher-gip · 2023-10-19T17:30:37Z

auth/login/auth-login.component.ts

@@ -74,6 +74,8 @@ export class AuthLoginComponent {
        }
    };

+    showPrivacyButton = !!environment.zeta.privacyLink;


As you will need this flag below, you should rather rename this bool to what it stands for. E. g. "privacyLinkDefined"

i rename the button see commit

johannesheucher-gip · 2023-10-19T17:33:25Z

auth/login/auth-login.component.ts

@@ -128,6 +130,12 @@ export class AuthLoginComponent {
    }


+    openPrivacyLink() {
+        window.open(environment.zeta.getPrivacyLink(this.i18n.language), '_blank').focus();


before executing this you should assert that getPrivacyLink is defined. The privacy button may not be able to call this function in that case, but someone else may.
Use the bool flag from above (e. g. privacyLinkDefined).

i add an if statement window.open(environment.zeta.getPrivacyLink(..... will be called when privacyLinkDefined ==true

…..... will be called when privacyLinkDefined ==true

johannesheucher-gip · 2023-10-20T08:25:43Z

auth/login/auth-login.component.ts

+            window.open(environment.zeta.getPrivacyLink(this.i18n.language), '_blank').focus();
+        }
+        else{
+            window.alert("PrivacyLink is not Defined");


better use a console.log here. For a severe problem it is okay to interrupt the user's flow with a window.alert, but I think, this is not the case here. What do you think?

the comment is realize with the last commit windows. alert wird jetzt console.log("PrivacyLink is not Defined"); verwendet

…ed"); verwendet

…ntfernt

johannesheucher-gip · 2023-10-31T15:39:53Z

auth/login/auth-login.component.html

-            [disabled]="pending"
-            (click)="login()"
-            xc-i18n
+                class="items-left" *ngIf="privacyLinkDefined"


please fix indentation

johannesheucher-gip · 2023-10-31T15:39:58Z

auth/login/auth-login.component.html

+                xc-i18n
+        >privacy-button</xc-button>
+        <xc-button
+                class="login-button items-right"


please fix indentation

#57 für den DHICB-9105 Datenschutzhinweis die Zeta Komponente Login m…

677e9be

…it einen Button ergänzt

rojansen linked an issue Oct 18, 2023 that may be closed by this pull request

Add Privacy Button to Login Mask #57

Closed

Merge branch 'main' into 57-add-privacy-button-to-login-mask-2

7a0848c

johannesheucher-gip suggested changes Oct 18, 2023

View reviewed changes

rojansen added 3 commits October 19, 2023 13:28

#57 Reviewkommnetare eingearbeitet

a1ebc27

Merge remote-tracking branch 'origin/57-add-privacy-button-to-login-m…

037f1d6

…ask-2' into 57-add-privacy-button-to-login-mask-2

#57 Reviewkommnetare eingearbeitet die vorher verlorengegangene Änder…

9b70279

…ung wieder eingefügt

johannesheucher-gip suggested changes Oct 19, 2023

View reviewed changes

rojansen added 2 commits October 19, 2023 21:52

#57 Reviewkommnetare Rename showPrivacyButton in privacyLinkDefined

56494de

#57 Reviewkommnetare the window.open(environment.zeta.getPrivacyLink(…

ec6468d

…..... will be called when privacyLinkDefined ==true

johannesheucher-gip suggested changes Oct 20, 2023

View reviewed changes

rojansen added 7 commits October 20, 2023 11:37

statt windows. alert wird jetzt console.log("PrivacyLink is not Defin…

b44fdd4

…ed"); verwendet

Es wurde der Reviewkommentar umgesetzt und die Variable privacyLink e…

1864229

…ntfernt

Es wurde der Reviewkommentar umgesetzt und die Variable privacyLink e…

c595083

…ntfernt

Es wurde der Reviewkommentar umgesetzt und die Variable privacyLink e…

461fba6

…ntfernt

Es wurde der Reviewkommentar umgesetzt und die Variable privacyLink e…

64f2168

…ntfernt

Es wurde der Reviewkommentar umgesetzt und die Variable privacyLink e…

40c9129

…ntfernt

Es wurde der Reviewkommentar umgesetzt und die Variable privacyLink e…

e0c4f23

…ntfernt

johannesheucher-gip suggested changes Oct 31, 2023

View reviewed changes

die Reviewkommnentare wurden umgesetzt

7c662d7

johannesheucher-gip approved these changes Oct 31, 2023

View reviewed changes

fixed linter error

908cc63

johannesheucher-gip merged commit 7306e3c into main Oct 31, 2023
4 checks passed

johannesheucher-gip deleted the 57-add-privacy-button-to-login-mask-2 branch October 31, 2023 16:18

johannesheucher-gip pushed a commit that referenced this pull request Nov 7, 2023

#57 added option for a privacy link inside login mask (#77)

b4f43fe

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#57 für den DHICB-9105 Datenschutzhinweis die Zeta Komponente Login m… #77

#57 für den DHICB-9105 Datenschutzhinweis die Zeta Komponente Login m… #77

rojansen commented Oct 18, 2023

johannesheucher-gip Oct 18, 2023

rojansen Oct 19, 2023

johannesheucher-gip Oct 19, 2023

rojansen Oct 19, 2023

johannesheucher-gip Oct 18, 2023

johannesheucher-gip Oct 18, 2023

rojansen Oct 19, 2023

johannesheucher-gip Oct 19, 2023

rojansen Oct 19, 2023

johannesheucher-gip Oct 19, 2023

johannesheucher-gip Oct 19, 2023

rojansen Oct 19, 2023

johannesheucher-gip Oct 19, 2023

rojansen Oct 19, 2023

johannesheucher-gip Oct 20, 2023

rojansen Oct 20, 2023

johannesheucher-gip Oct 31, 2023

johannesheucher-gip Oct 31, 2023

#57 für den DHICB-9105 Datenschutzhinweis die Zeta Komponente Login m… #77

#57 für den DHICB-9105 Datenschutzhinweis die Zeta Komponente Login m… #77

Conversation

rojansen commented Oct 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment