Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show compact posts #22

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

pbui
Copy link
Contributor

@pbui pbui commented Jul 26, 2023

Add a new UI setting for showing compact posts:

  • Show a small thumbnail to the right of the metadata and title if a thumbnail is available or if the post is an image
  • Do not show normal thumbnail or text bodies.

Here is a screenshot of what the Frontpage looks like on the desktop (Firefox):

Screenshot from 2023-07-26 10-02-06

Here is a community screenshot:

Screenshot from 2023-07-26 10-04-33

Here is the Frontpage on mobile (Firefox/Android):

le6g

Here is a community screenshot on mobile:

gSOk

If you need me to refactor or modify the code, I would welcome the opportunity to do so. Thanks for starting this great project!

@vercel
Copy link

vercel bot commented Jul 26, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Xyphyn on Vercel.

@Xyphyn first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
photon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 5:30pm

@Xyphyn
Copy link
Owner

Xyphyn commented Jul 26, 2023

For some reason the title of the post seems to have no padding with the metadata. I'd also prefer if every image was square, similar to lemmy-ui, and maybe make it a block instead of inline

@pbui
Copy link
Contributor Author

pbui commented Jul 26, 2023

OK, I can look into that... I'm not very familiar with CSS or Tailwind, but I'll see what I can do.

Add a new UI setting for showing compact posts:

- Show a small thumbnail to the right of the metadata and title if a
  thumbnail is available or if the post is an image
- Do not show normal thumbnail or text bodies.
@pbui
Copy link
Contributor Author

pbui commented Jul 26, 2023

Ok, I've updated the PR so that the images are square and there is now a gap again between the metadata and the title.

Here are the update screenshots:

Desktop:

Screenshot from 2023-07-26 12-47-21

Mobile:

kqxo

Let me know if you want any other changes.

@Xyphyn
Copy link
Owner

Xyphyn commented Jul 26, 2023

Looks good!

@Xyphyn Xyphyn merged commit e028113 into Xyphyn:main Jul 26, 2023
2 checks passed
Copy link

cloudflare-workers-and-pages bot commented Sep 11, 2024

Deploying photon with  Cloudflare Pages  Cloudflare Pages

Latest commit: 921b8f1
Status: ✅  Deploy successful!
Preview URL: https://71f219d5.photon-8na.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants