Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide guest actions in locked instance mode #379

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

sevonj
Copy link
Contributor

@sevonj sevonj commented Jul 25, 2024

Related issues: #328

This hides guest login / logout buttons if photon is linked to an instance. Adding guests doesn't work with linked instances, which made guest logout especially infuriating since the only way I could get the guest user back was by removing logged in accounts.

Before

Screenshot_20240725_133540

image

After

Screenshot_20240725_134112

Screenshot_20240725_133601

Copy link

vercel bot commented Jul 25, 2024

@sevonj is attempting to deploy a commit to the Xylight's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
photon ✅ Ready (Inspect) Visit Preview Jul 25, 2024 4:03pm

@Xyphyn Xyphyn merged commit 998dcb7 into Xyphyn:main Jul 25, 2024
1 check passed
@sevonj
Copy link
Contributor Author

sevonj commented Jul 25, 2024

I think you forgot the add guest button in the accounts page.

It had the check already?

{#if !LINKED_INSTANCE_URL}
<Button href="/login/guest" size="lg">
<Icon slot="prefix" src={Plus} size="16" mini />
{$t('account.addGuest')}
</Button>
{/if}

@Xyphyn
Copy link
Owner

Xyphyn commented Jul 25, 2024

I think you forgot the add guest button in the accounts page.

It had the check already?

{#if !LINKED_INSTANCE_URL}
<Button href="/login/guest" size="lg">
<Icon slot="prefix" src={Plus} size="16" mini />
{$t('account.addGuest')}
</Button>
{/if}

Yeah I realized, I couldn't view the full file on mobile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants