-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout causing panic #13
Comments
Thank you for the heads up, I'll try to increase the default timeout as well as handle this panic better. |
Merged #15 in, should be better on slow connections now, but I think the only way to completely resolve this issue would be to handle failing download attempts in a safe manner (e.g. continue retrieving other assets if one fails). |
Thanks, it handling some but still timing out of others |
I improved the code to treat all network errors as blank responses, this should help saving pages with resources that timeout or throw other kinds of errors. Please let me know if it got rid of the panic. I'm thinking of adding a |
thread 'main' panicked at 'called maybe the best solution is retrying if panic happens |
@TerminusBot it happens for the very first request, right? |
@snshn totally right |
I'll look into it this weekend, thank you for the info |
I just set the timeout 60 and it works very well now. |
@TerminusBot I've added a new flag ( |
Sorry, 60 is good enough for me and it works well in production, so I may not test.But you have added the new parameter and we have an easy way to solve this bug. |
@TerminusBot I bumped it to 120 seconds, that seems to be what Chrome and FF are doing regarding network request timeout. If you do |
With a slow/unreliable internet connection then keep getting this error:
The text was updated successfully, but these errors were encountered: