722 improved UI on pathways page #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a 2 divs so that it would not print the name and remove the hover from minors
Hide the footer of the pop up
sophiachen646
approved these changes
Jul 21, 2023
aruan20
approved these changes
Jul 21, 2023
EggyRepublic
added a commit
that referenced
this pull request
Aug 9, 2023
This reverts commit 0d8ccf7.
EggyRepublic
added a commit
that referenced
this pull request
Aug 21, 2023
* Added json file (#725) - added professor json to rpi_data folder * Documentation (#759) readme for how to view tables in docker * Professor Page (#688) * started professor page * starting professor explore page * worked on professor functions * got alphabet-sorted professor page working * created department view * fixed spacing, buttons, and alphabetization * created professor pop-up * added professors header button * made professor profile page * professor header button icon * removed professor phone number * fixed heading alignment * fixed merge conflict * updated Department --------- Co-authored-by: ragar3 <qN%ZMi6Q3nq7Qi> Co-authored-by: jonha1 <jonnyha888@gmail.com> * beep boop Github Action Master Branch CI Prettier hard at work * valid discord invite link (#754) updated the discord invite link that doesn't expire * Hover in pathways (#748) * fixed hover over sorting options there is now a hover over the two sorting options in the pathways page * fixed hover in pathways the hover over the subjects in both light and dark mode work when hovering over them * beep boop Github Action Master Branch CI Prettier hard at work * Course conflict message (#742) * Course conflict message Attempted to add a pop up when there's conflicting courses while trying to add courses to a schedule. * original before edit fixed it so that there's no issue * got rid of commented code removed some code that I tried to do that wasn't working * added popup added pop up, info inside is not correct, but will appear if there is a course conflict * fixed pop up will appear now, and list conflicting courses * changed display message changed the display message on the calendar to show conflicting courses * fixed line of code * Removed pop up removed the pop up and changed the display message * fixed credits when there's a course conflict got rid of the credits that are showing when there's a course conflict. it used to show the total number of credits for the classes even though there's a course conflict --------- Co-authored-by: sophiachen646 <sophiachen646@gmail.com> * beep boop Github Action Master Branch CI Prettier hard at work * 722 improved UI on pathways page (#729) * Improved IU Added a 2 divs so that it would not print the name and remove the hover from minors * Removed Buttons Hide the footer of the pop up * beep boop Github Action Master Branch CI Prettier hard at work * 723 more detailed explore page with sorting options (#753) * Added buttons and started implementing functions The buttons to list the departments by alphabetical order and by school were created. The functions to sort the departments alphabetically and separated into two columns are beginning to be implemented. * Added functions to sort departments alphabetically The functions alphDict() and alphDepartmentObjects() were implemented to help alphabetically sort the departments. However, I was unable to test it out because the website keeps saying Loading Departments. * Fixed code so that it appears on the website The code is fixed so that the alphabetical sections with the respective departments show on the website. However, each alphabetical section are not in alphabetical order. * Fix how alphabetical sections were arranged The departments are now sorted by their first letter and each section is separated into two columns with the first 13 letters in the first column and the rest in the second column. * Fixed so that website don't display empty sections Previously, the website had a section for every letter in the alphabet even if there were no departments that start with that letter. Now, it only displays the sections that are not empty (has departments that start with the letter). * Remove extra code Removed alphabet array in alphDeptDict() because it wasn't being used. * Found where department code long names are stored The long names for the department codes INQR and STSO are added, but it still doesn't display on the website. * HASS typo fixed HASS typo --------- Co-authored-by: jonha1 <jonnyha888@gmail.com> * beep boop Github Action Master Branch CI Prettier hard at work * 718 finals schedule days don't line up (#737) * Change Font Size to be More Responsive The font size now changes based on the width of the browser window, which prevents the day labels from taking two lines and as a result prevents some columns from shifting down. However, when the browser window becomes smaller, the text becomes hard to read when it has the space to be a bigger font size. A possible solution is to create a new function that would change the font size based on the width of the grid boxes. * Try to Implement Function to Change Font Size Based on Grid Box Size The function is supposed to take in the length of day label and if it's longer than the length of the grid box, then it will shrink the font size. However, it is currently not working. I made the font size slightly bigger compared to last time. * Revert back to just using vw and not a function Function still doesn't work, so code is reverted back to just using vw. Font size is updated to 0.85 vw instead of 0.9vw because the grid lines don't line up at the larger size. * beep boop Github Action Master Branch CI Prettier hard at work * Fix website (#768) * revert * Revert "revert" This reverts commit 0fbd166. * Revert "beep boop Github Action Master Branch CI Prettier hard at work" This reverts commit a43c612. * Revert "718 finals schedule days don't line up (#737)" This reverts commit cde1586. * Revert "beep boop Github Action Master Branch CI Prettier hard at work" This reverts commit 946354a. * Revert "723 more detailed explore page with sorting options (#753)" This reverts commit 10bca13. * Sorting (#769) * Revert "Fix website (#768)" This reverts commit f7ea6aa. * no INQR removed * got rid of INQR * Revert "got rid of INQR" This reverts commit 82763eb. * Revert "Sorting (#769)" This reverts commit 2b881bf. * Revert (#771) * revert * Revert "revert" This reverts commit 0fbd166. * Revert "beep boop Github Action Master Branch CI Prettier hard at work" This reverts commit a43c612. * Revert "718 finals schedule days don't line up (#737)" This reverts commit cde1586. * Revert "beep boop Github Action Master Branch CI Prettier hard at work" This reverts commit 946354a. * Revert "723 more detailed explore page with sorting options (#753)" This reverts commit 10bca13. * debugging (#770) * Fix website (#768) * revert * Revert "revert" This reverts commit 0fbd166. * Revert "beep boop Github Action Master Branch CI Prettier hard at work" This reverts commit a43c612. * Revert "718 finals schedule days don't line up (#737)" This reverts commit cde1586. * Revert "beep boop Github Action Master Branch CI Prettier hard at work" This reverts commit 946354a. * Revert "723 more detailed explore page with sorting options (#753)" This reverts commit 10bca13. * Sorting (#769) * Revert "Fix website (#768)" This reverts commit f7ea6aa. * no INQR removed * got rid of INQR * Revert "got rid of INQR" This reverts commit 82763eb. * Revert "Sorting (#769)" This reverts commit 2b881bf. * Revert "Revert "Sorting (#769)"" This reverts commit a768115. * Revert "Revert "got rid of INQR"" This reverts commit 8494629. * Revert "got rid of INQR" This reverts commit 82763eb. * Revert "Sorting (#769)" This reverts commit 2b881bf. * Revert "Fix website (#768)" This reverts commit f7ea6aa. * Revert "beep boop Github Action Master Branch CI Prettier hard at work" This reverts commit a43c612. * Revert "718 finals schedule days don't line up (#737)" This reverts commit cde1586. * Revert "beep boop Github Action Master Branch CI Prettier hard at work" This reverts commit 946354a. * Revert "723 more detailed explore page with sorting options (#753)" This reverts commit 10bca13. * Revert "beep boop Github Action Master Branch CI Prettier hard at work" This reverts commit 18f3dcf. * Revert "722 improved UI on pathways page (#729)" This reverts commit 0d8ccf7. * added certbot (let's encrypt) * alpine :( * pip * Revert "pip" This reverts commit 157143e. * Revert "beep boop Github Action Master Branch CI Prettier hard at work" This reverts commit 9abb84d. * Revert "Course conflict message (#742)" This reverts commit ef3225c. * Revert "beep boop Github Action Master Branch CI Prettier hard at work" This reverts commit 83a061b. * Revert "Hover in pathways (#748)" This reverts commit b2b4276. * remove certbot --------- Co-authored-by: Jonathan Ha <78988736+jonha1@users.noreply.github.com> Co-authored-by: ragar3 <112728733+ragar3@users.noreply.github.com> Co-authored-by: jonha1 <jonnyha888@gmail.com> Co-authored-by: I'm a Github Action <beepboop@github.com> Co-authored-by: sophiachen646 <72230685+sophiachen646@users.noreply.github.com> Co-authored-by: shirley <shirleytom45@gmail.com> Co-authored-by: sophiachen646 <sophiachen646@gmail.com> Co-authored-by: Amanda Ruan <90737103+aruan20@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
closes #722
Database Changes/Migrations
None
Test Modifications
None
Test Procedure
Photos
Before:
After:
Additional Info
Originally, there was a footer at the bottom with two buttons that said Cancel and OK. However, since the two buttons and the X at the top all close the pop up, I thought it would be best to remove both buttons.