-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Options include setting for Culture #139
Conversation
@304NotModified @NKnusperer Opinion on #139 (comment) appreciated |
Nice PRs! Will try to review this weekend! |
@304NotModified @NKnusperer |
CultureInfo.InvariantCulture
Yes those should be internal
Sounds logical to me :) |
Assert.IsTrue(ser.DimensionsAttributeName == opt.AttributeName.Dimensions); | ||
Assert.IsTrue(ser.RealTypeAttributeName == opt.AttributeName.RealType); | ||
Assert.IsTrue(ser.MaxRecursion == opt.MaxRecursion); | ||
ser.DefaultExceptionType.Should().Be(opt.ExceptionBehavior); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice
@axunonb I'am in vacation till the end of the week. I will try to catch up next week. |
@NKnusperer have a good holiday! |
@NKnusperer Hi, hope you some beautiful days off ;-) |
With exceptions you're talking about the message?
Yes.
Absolutely. |
Closes #80
Breaking changes to v2.x (added
CultureInfo
parameter):ReflectionUtils.ConvertBasicType(object value, Type dstType, CultureInfo culture)
XMLUtilts.ToXmlValue(this object self, CultureInfo culture)
XMLUtilts.CreateAttribute(XElement baseElement, string location, XName attrName, object attrValue, XNamespace documentDefaultNamespace, CultureInfo culture)
XMLUtilts.AddPreserveSpaceAttribute(XElement element, CultureInfo culture)
XMLUtilts.ToXmlValue(this object self, CultureInfo culture)
XMLUtilts.AddAttributeNamespaceSafe(this XElement parent, XName attrName, object attrValue, XNamespace documentDefaultNamespace, CultureInfo culture)
XMLUtilts.AddXmlContent(this XElement self, object contentValue, CultureInfo culture)
Open for discussion:
Exception
s useCultureInfo.InvariantCulture
,CultureInfo.CurrentCulture
orOptions.Culture
. The latter is complex with no value IMHO.internal
thanpublic
?