feat(lint): 添加qunar默认lint规则

Author: yuhaoju

lib/config/eslint.json

@@ -1,13 +1,33 @@
 {
-    "env": {
-        "browser": true,
-        "commonjs": true,
-        "node": false
-    },
-    "extends": ["eslint:recommended"],
-    "globals": [
-        "$", "$$", "jQuery", "Promise"
-    ],
-    "rules": {},
-    "ignorePattern": ["/node_modules/*", "/bower_components/*", "/dev/*", "/prd/*"]
+  "env": {
+    "browser": true,
+    "commonjs": true,
+    "node": true
+  },
+  "globals": [
+    "$",
+    "$$",
+    "jQuery",
+    "Promise"
+  ],
+  "rules": {
+      "no-with": "error",
+      "no-array-constructor": "error",
+      "no-debugger": "error",
+      "no-sequences": "error",
+      "no-dupe-args": "error",
+      "no-inner-declarations": "error",
+      "no-unreachable": "error",
+      "no-octal": "error",
+      "no-dupe-keys": "error",
+      "comma-dangle": ["error", "never"],
+      "no-unused-vars": "error"
+  },
+  "ignorePattern": [
+    "/fekit_modules/*",
+    "/node_modules/*",
+    "/bower_components/*",
+    "/dev/*",
+    "/prd/*"
+  ]
 }

lib/models/Project.js

@@ -245,23 +245,22 @@ var Project = function () {
                 CLIEngine = requireg(sysPath.join(this.cwd, 'node_modules/', 'eslint')).CLIEngine;
             }
 
-            // prepare eslint config file
-            // const configFilePath = sysPath.join(__dirname, '../../' ,'.eslintrc.json')
+            // 优先使用本地配置
             var eslintExts = ['.js', '.yaml', '.yml', '.json', ''];
             var configFilePath = '';
             eslintExts.forEach(function (eslintExtItem) {
                 if (_this3._fileExists(sysPath.join(_this3.cwd, '.eslintrc' + eslintExtItem))) {
                     configFilePath = sysPath.join(_this3.cwd, '.eslintrc' + eslintExtItem);
+                    _this3.eslintConfig = requireg(configFilePath);
                 }
             });
 
+            // 本地无lint配置，创建.eslintrc.json
             if (!configFilePath) {
                 configFilePath = sysPath.join(this.cwd, '.eslintrc.json');
                 fs.writeFileSync(configFilePath, JSON.stringify(this.eslintConfig, null, '  '));
             }
 
-            this.eslintConfig.configFile = configFilePath;
-
             var cli = new CLIEngine(this.eslintConfig),
                 report = cli.executeOnFiles(this._getLintFiles(dir, 'js')),
                 formatter = cli.getFormatter();

src/config/eslint.json

@@ -1,13 +1,33 @@
 {
-    "env": {
-        "browser": true,
-        "commonjs": true,
-        "node": false
-    },
-    "extends": ["eslint:recommended"],
-    "globals": [
-        "$", "$$", "jQuery", "Promise"
-    ],
-    "rules": {},
-    "ignorePattern": ["/node_modules/*", "/bower_components/*", "/dev/*", "/prd/*"]
+  "env": {
+    "browser": true,
+    "commonjs": true,
+    "node": true
+  },
+  "globals": [
+    "$",
+    "$$",
+    "jQuery",
+    "Promise"
+  ],
+  "rules": {
+      "no-with": "error",
+      "no-array-constructor": "error",
+      "no-debugger": "error",
+      "no-sequences": "error",
+      "no-dupe-args": "error",
+      "no-inner-declarations": "error",
+      "no-unreachable": "error",
+      "no-octal": "error",
+      "no-dupe-keys": "error",
+      "comma-dangle": ["error", "never"],
+      "no-unused-vars": "error"
+  },
+  "ignorePattern": [
+    "/fekit_modules/*",
+    "/node_modules/*",
+    "/bower_components/*",
+    "/dev/*",
+    "/prd/*"
+  ]
 }

src/models/Project.js

@@ -216,16 +216,17 @@ class Project {
             CLIEngine = requireg(sysPath.join(this.cwd, 'node_modules/', 'eslint')).CLIEngine
         }
 
-        // prepare eslint config file
-        // const configFilePath = sysPath.join(__dirname, '../../' ,'.eslintrc.json')
+        // 优先使用本地配置
         const eslintExts = ['.js', '.yaml', '.yml', '.json', '']
         let configFilePath = ''
         eslintExts.forEach((eslintExtItem) => {
             if(this._fileExists(sysPath.join(this.cwd, '.eslintrc' + eslintExtItem))) {
                 configFilePath = sysPath.join(this.cwd, '.eslintrc' + eslintExtItem)
+                this.eslintConfig = requireg(configFilePath)
             }
         })
 
+        // 本地无lint配置，创建.eslintrc.json
         if(!configFilePath) {
             configFilePath = sysPath.join(this.cwd, '.eslintrc.json')
             fs.writeFileSync(
@@ -234,8 +235,6 @@ class Project {
             );
         }
 
-        this.eslintConfig.configFile = configFilePath
-
         const cli = new CLIEngine(this.eslintConfig),
             report = cli.executeOnFiles(this._getLintFiles(dir, 'js')),
             formatter = cli.getFormatter();