Change fog distance from statute miles to nautical miles #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah good spot. Will review. |
NodokaHanamura
added
scenery
|
Had a quick look. Looks good, but need to check it compiled to see it working, and double check it against the wording of the menu. May require an update to the language file to reflect this. |
Skipper-is
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Does the wording in the dialogue need to change to go along with this?
|
It might be worth moving these conversions & other hard-coded values into a YSFlight constants header/class eventually (just something to think about) |
|
it would be nice to have unit conversion or definition handled in one unified place. |
|
There are some, well, there is a meters to NM, not sure if there is a visa
versa
…On Tue, 27 Jun 2023, 22:51 decaff42, ***@***.***> wrote:
it would be nice to have unit conversion or definition handled in one
unified place.
—
Reply to this email directly, view it on GitHub
<#31 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG2ZPNPN6YTVILSFP4OJ65LXNNIXJANCNFSM6AAAAAAZSIIHUY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a couple of other instances of
1609.0infsguinewflightdialog.cpprelated to the fog visibility distance. I changed these to1852.0so that these distances are in nautical miles.