fix Gulp and Grunt commenting and snippets, issue #72 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 This would help me out loads. Please merge this @YabataDesign =) |
|
👍 |
|
It's boring that the theme forces you to use the gulpfile syntax. I want the default javascript syntax on gulpfile. |
|
@YabataDesign Any reason the PR hasn't been merged and this issue is still open? Been dealing with this problem for a while now and would appreciate my standard key commands to work as expected per my comments in #72. Appreciate the effort @mknabe |
|
This repo doesn't look like it is being actively maintained anymore. @vikjam has forked it though and is much more active! |
vikjam
added a commit
to vikjam/afterglow-theme
that referenced
this pull request
Jan 24, 2016
Merging in fix Gulp and Grunt commenting and snippets, issue YabataDesign#72 YabataDesign#95
45 tasks
|
Thanks so much @YabataDesign! Much appreciated 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #72. Changed the scopeName for the Gulp and Grunt syntax definitions so they inherit the JavaScript/CoffeeScript scope. This allows snippets and commenting to work like it would in a JS file.