This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
better output handler response header check #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, although the functional tests are failing, but might not be related to this PR. /cc @lzhan can you take care of this? |
|
@lzhan, a unit test for this is going to be difficult because @jarnoux removed the piece of logic that we controlled in favor of something controlled by express directly. What we might need to do is to review if we were doing any unit test around that manual verification, and remove them. In the other hand, if we want to really test this, we might want to use |
|
@caridy Got it. Thanks. I will update HISTORY file and merge this pr. |
lzhan
pushed a commit
that referenced
this pull request
Oct 17, 2013
better output handler response header check
lzhan
pushed a commit
that referenced
this pull request
Oct 18, 2013
update history file, add entry for pr #1264
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output handler was maintaining its own guard to prevent writing headers when they are already sent. This is not an efficient solution as the headers can potentially have been written by virtually anyone that has access to the response. This was causing our app to crash and stop when we had two errors.