Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: client_handler.py #119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bugfix: client_handler.py #119

wants to merge 1 commit into from

Conversation

miili
Copy link

@miili miili commented Aug 3, 2022

More defensive closing of a broken connection.

We saw a rant of messages on instable/unreliable connections:

2022-07-28T08:23:17.804100764Z WARNING:asyncio:socket.send() raised exception.
2022-07-28T08:23:17.804102147Z DEBUG:amqtt.mqtt.protocol.handler:Broker closed connection
2022-07-28T08:23:17.804103500Z WARNING:asyncio:socket.send() raised exception.
2022-07-28T08:23:17.804104932Z DEBUG:amqtt.mqtt.protocol.handler:Broker closed connection
2022-07-28T08:23:17.804106265Z WARNING:asyncio:socket.send() raised exception.
2022-07-28T08:23:17.804107587Z DEBUG:amqtt.mqtt.protocol.handler:Broker closed connection
2022-07-28T08:23:17.804108930Z WARNING:asyncio:socket.send() raised exception.

These were thrown 10 k/s and flooded logs and the buffer, leading to an instable system.

I think this is due to an unhandled closed connection. Please review the attached MR.

More defensive closing of a broken connection.
@miili
Copy link
Author

miili commented Aug 11, 2022

ping @FlorianLudwig

1 similar comment
@miili
Copy link
Author

miili commented Oct 22, 2022

ping @FlorianLudwig

@FlorianLudwig
Copy link
Member

@miili sorry for the long delay, looks good to me! thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants