don't filter topics if its explicit disabled

[edenhaus]

During the investigation of #92 I found out, that even when the topic check is disabled via config (topic-check": {"enabled": False}). All plugins will be used to check for topic filtering.

The reason is that in the method topic_filtering the value None is passed for filter_plugins to the method map_plugin_coro

amqtt/amqtt/broker.py

Lines 728 to 738 in 8961b8f

	topic_plugins = None
	topic_config = self.config.get("topic-check", None)
	if topic_config and topic_config.get("enabled", False):
	topic_plugins = topic_config.get("plugins", None)
	returns = await self.plugins_manager.map_plugin_coro(
	"topic_filtering",
	session=session,
	topic=topic,
	action=action,
	filter_plugins=topic_plugins,
	)

In the manager then, if the value is None all available plugins will be used.

amqtt/amqtt/plugins/manager.py

Lines 167 to 169 in 8961b8f

	p_list = kwargs.pop("filter_plugins", None)
	if p_list is None:
	p_list = [p.name for p in self.plugins]

My fix will immediately return True (topic_result) if in the topic-check-configuration explicit enabled was set to False.
If the key enabled is missing all plugins will be used as it was done before (backward compatibility).

[edenhaus]

As workaround until this PR is merged, you can add the following to your config:
"topic-check": {"enabled": True, "plugins": []}

[FlyingDiver]

This bit me today as well.

[HerrMuellerluedenscheid]

LGTM @FlorianLudwig

[edenhaus]

@FlorianLudwig Can this be merged or do I miss something?