Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating, deleting, listing, showing users #2

Merged
merged 7 commits into from
Feb 3, 2021

Conversation

fishnix
Copy link
Contributor

@fishnix fishnix commented Jan 25, 2021

This was a bit more work than I anticipated... so far this supports:

  • listing users
  • creating users
  • showing details about a user
  • deleting users

TODO:

  • reseting access keys
  • filling in details about groups and access keys when showing details about a user
  • fill in some tests

@damnski
Copy link

damnski commented Feb 1, 2021

Looks really good. A huge commit. Just a couple comments.

Copy link

@tenyo tenyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! A few comments/questions 👍

api/orchestration_users.go Outdated Show resolved Hide resolved
api/orchestration_users.go Outdated Show resolved Hide resolved
api/handlers_users.go Show resolved Hide resolved
api/orchestration_users.go Show resolved Hide resolved
api/orchestration_users.go Outdated Show resolved Hide resolved
api/orchestration_users.go Show resolved Hide resolved
api/routes.go Outdated Show resolved Hide resolved
iam/groups.go Show resolved Hide resolved
iam/policy.go Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@tenyo
Copy link

tenyo commented Feb 3, 2021

Excellent! 👍

@fishnix fishnix merged commit 68cd4a1 into master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants