Create custom IAM role for each cluster #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 1, 2019 14:13
fishnix
reviewed
Oct 3, 2019
There was a problem hiding this comment.
This looks really good! I think we should shoot for 80% coverage on the libraries. It looks like just the one method (that should probably end up in the handler or orchestration) isn't covered.
ok github.com/YaleSpinup/ecs-api/iam 0.019s coverage: 66.2% of statements
Except for that and the few return signature changes, I think this looks good to go. Thanks!
api/handlers_orchestration.go
Outdated
Comment on lines
75
to
77
| // if ecsService.DefaultExecutionRoleArn != "" { | ||
| // orchestration.DefaultExecutionRoleArn = aws.String(ecsService.DefaultExecutionRoleArn) | ||
| // } |
iam/errors.go
Outdated
| if aerr, ok := errors.Cause(err).(awserr.Error); ok { | ||
| switch aerr.Code() { | ||
| case | ||
|
|
iam/errors.go
Outdated
| iam.ErrCodeEntityAlreadyExistsException: | ||
|
|
||
| return apierror.New(apierror.ErrConflict, msg, aerr) | ||
|
|
iam/iam.go
Outdated
| } | ||
|
|
||
| // DefaultTaskExecutionRole generates the default role (if it doesn't exist) for ECS task execution and returns the ARN | ||
| func (i *IAM) DefaultTaskExecutionRole(ctx context.Context, path string) (*string, error) { |
There was a problem hiding this comment.
I would return string unless you use the nil value
| } | ||
|
|
||
| return roleOutput.Role.Arn, nil | ||
| } |
There was a problem hiding this comment.
It seems like this orchestration doesn't belong here ultimately, but its probably okay for now.
iam/role.go
Outdated
| } | ||
|
|
||
| // DeleteRole handles deleting an IAM role | ||
| func (i *IAM) DeleteRole(ctx context.Context, input *iam.DeleteRoleInput) (*iam.DeleteRoleOutput, error) { |
There was a problem hiding this comment.
This should just return error
type DeleteRoleOutput struct {
// contains filtered or unexported fields
}
iam/role.go
Outdated
| ) | ||
|
|
||
| // CreateRole handles creating an IAM role | ||
| func (i *IAM) CreateRole(ctx context.Context, input *iam.CreateRoleInput) (*iam.CreateRoleOutput, error) { |
There was a problem hiding this comment.
This should just return *iam.Role, error
type CreateRoleOutput struct {
// A structure containing details about the new role.
//
// Role is a required field
Role *Role `type:"structure" required:"true"`
// contains filtered or unexported fields
}
iam/role.go
Outdated
| } | ||
|
|
||
| // PutRolePolicy handles attaching an inline policy to IAM role | ||
| func (i *IAM) PutRolePolicy(ctx context.Context, input *iam.PutRolePolicyInput) (*iam.PutRolePolicyOutput, error) { |
There was a problem hiding this comment.
This should just return error
type PutRolePolicyOutput struct {
// contains filtered or unexported fields
}
orchestration/orchestration.go
Outdated
| type Orchestrator struct { | ||
| // https://docs.aws.amazon.com/sdk-for-go/api/service/ecs/#ECS | ||
| ECS *ecs.ECS | ||
| // https://docs.aws.amazon.com/sdk-for-go/api/service/iam/#IAM | ||
| IAM iam.IAM | ||
| // IAM iamiface.IAMAPI |
| } | ||
|
|
||
| input.TaskDefinition.ExecutionRoleArn = roleARN | ||
| } |
added 2 commits
October 3, 2019 15:12
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for creating/deleting IAM roles. The creation orchestration workflow changes slightly so it will now create a separate IAM role for each cluster instead of using the same default role for all services. This way ECS services in the same cluster can decrypt their own secrets (in SSM Parameter Store) but not secrets belonging to other clusters.