Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return service tags with get service request #30

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Conversation

fishnix
Copy link
Contributor

@fishnix fishnix commented Feb 19, 2020

It looks like AWS doesn't return tags with the request to describe a service even though there is a property in the struct. This makes the call to get the tags and appends them to the response as a top level Tags: property.

Copy link
Contributor

@tenyo tenyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@fishnix fishnix merged commit 2024ccf into master Feb 21, 2020
@fishnix fishnix deleted the cf322-get-tags branch March 28, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants