Delete default task execution role on recursive delete of service #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fishnix
commented
Mar 8, 2021
fishnix
commented
- Cleanup default task execution role on recursive delete of service.
- Fix a bug where we always try to delete the cluster.
damnski
reviewed
Mar 9, 2021
| @@ -107,3 +107,39 @@ func (i *IAM) GetRolePolicy(ctx context.Context, role, policy string) (string, e | |||
|
|
|||
| return d, nil | |||
| } | |||
|
|
|||
| func (i *IAM) ListRolePolicies(ctx context.Context, role string) ([]string, error) { | |||
There was a problem hiding this comment.
missing the function comment, here and a couple more places. I can't remember if non-exported functions conventionally need function comments.
|
looks good. Just a few comments. Does the circleci failure matter? |
FishNecks
approved these changes
Mar 9, 2021
tenyo
reviewed
Mar 9, 2021
tenyo
reviewed
Mar 9, 2021
fishnix
added a commit
that referenced
this pull request
Mar 11, 2021
* manage default task execution policy for container services * Delete default task execution role on recursive delete of service (#45)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.