Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup some log output, always tag on update #47

Merged
merged 3 commits into from
Apr 14, 2021
Merged

cleanup some log output, always tag on update #47

merged 3 commits into from
Apr 14, 2021

Conversation

fishnix
Copy link
Contributor

@fishnix fishnix commented Apr 7, 2021 •
edited
Loading

  • cleanup log messages
  • always tag on update (to make sure we get the latest tag set for all resources (roles, td, service, secrets, etc)

@fishnix fishnix changed the title cleanup some log output to make logs easier to follow cleanup some log output, always tag on update Apr 9, 2021
tenyo
tenyo approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@tenyo tenyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@damnski
Copy link
Contributor

damnski commented Apr 12, 2021

lots of tags, more inline documentation/comments are good

@fishnix fishnix merged commit 79d44f2 into master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenyo tenyo tenyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fishnix @damnski @tenyo