Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop running tasks when deleting a task definition if force is passed #61

Merged
merged 2 commits into from
Oct 4, 2021
Merged

stop running tasks when deleting a task definition if force is passed #61

merged 2 commits into from
Oct 4, 2021

Conversation

fishnix
Copy link
Contributor

@fishnix fishnix commented Sep 21, 2021

No description provided.

btassone
btassone approved these changes Sep 23, 2021
View reviewed changes
Copy link

@btassone btassone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Looks good, just have a question.

orchestration/orchestration_taskdef.go Show resolved Hide resolved
orchestration/orchestrator.go Show resolved Hide resolved
tenyo
tenyo approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@tenyo tenyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
If this background thread fails for some reason to stop the running tasks, there's no way currently to know that from the UI, right? The task def will just remain there. I guess eventually all these async tasks should be using flywheel

orchestration/orchestration_taskdef.go Outdated Show resolved Hide resolved
@fishnix
Copy link
Contributor Author

fishnix commented Oct 4, 2021

@tenyo yes correct - i didnt want to introduce flywheel to this API though just as a one off

@fishnix fishnix merged commit f728c39 into master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btassone btassone btassone approved these changes

@tenyo tenyo tenyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fishnix @btassone @tenyo