Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Show and Delete endpoints for secrets management #9

Merged
merged 4 commits into from
Jul 9, 2019
Merged

Add Show and Delete endpoints for secrets management #9

merged 4 commits into from
Jul 9, 2019

Conversation

fishnix
Copy link
Contributor

@fishnix fishnix commented Jul 6, 2019

  • Add endpoint to delete secrets with a window query param
  • Add endpoint to show secrets (metadata)
  • Modify list endpoint to only return ARNs

tenyo
tenyo reviewed Jul 8, 2019
View reviewed changes
Copy link
Contributor

@tenyo tenyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few questions

api/handlers_secrets.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
secretsmanager/secrets_test.go Show resolved Hide resolved
damnski
damnski reviewed Jul 8, 2019
View reviewed changes
secretsmanager/secrets.go Outdated Show resolved Hide resolved
@damnski
Copy link
Contributor

damnski commented Jul 8, 2019

looks good, other than a documentation nit.

@tenyo
Copy link
Contributor

tenyo commented Jul 9, 2019

👍

@fishnix fishnix merged commit 79dd7f2 into cf322-secrets-endpoints Jul 9, 2019
fishnix added a commit that referenced this pull request Jul 9, 2019
@fishnix
Add endpoints for secretsmanager routes (create/list) (#8)
81e8430 
* Add endpoints for secretsmanager routes. Add functionality to create and list secrets (limited to the configured org). Add graceful shutdown for server.
* Add Show and Delete endpoints for secrets management (#9)
* Show, delete secrets
* filter list on arbitrary tag pairs, change org tag to spinup:org
@fishnix fishnix deleted the cf322-more-secrets branch March 28, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damnski damnski damnski left review comments

@tenyo tenyo tenyo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fishnix @damnski @tenyo