Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old OpenDaylight internal config system (CSS) YANG models #554

Closed
vorburger opened this issue Jan 22, 2019 · 4 comments
Closed

Remove old OpenDaylight internal config system (CSS) YANG models #554

vorburger opened this issue Jan 22, 2019 · 4 comments

Comments

@vorburger
Copy link
Contributor

vorburger commented Jan 22, 2019

Modes such as the opendaylight-dom-broker-impl.yang describe internal Java object wiring of OpenDaylight internal config system (CSS), and IMHO make no sense to / could never be of any real world interest outside of ODL's internal code...

Further and more importantly, these have long ago disappeared from OpenDaylight (me and others have replaced what this used to be used for by regular Java dependency injection; initially OSGi Blueprint XML and more recently even simpler @javax.annotation.Inject).

Would you guys like a PR to to git rm e.g. all of these ?

@tnadeau

@miroslavKovacPantheon
Copy link
Contributor

I would be ok with removing modules from ODP folder of what you proposed.. but certainly not the yang-catalog@2018-04-03.yang module from ietf-extracted-YANG-modules and Cisco-IOS-XE-wireless-access-point-oper.yang from cisco/xe/16101 folder which are in there included too. but that is probably what you meant anyway.

But still @tnadeau should have a last word for this and maybe @bclaise and @einarnn might have some opinion on this.

@bclaise
Copy link
Contributor

bclaise commented Jan 22, 2019

These YANG modules are old. Yes, a cleanup, along with posting the latest YANG modules, would be welcome.

@tnadeau
Copy link
Contributor

tnadeau commented Jan 22, 2019 via email

@vorburger
Copy link
Contributor Author

These YANG modules are old. Yes, a cleanup,

#555

These models are meant to mimic what is used in ODL, so the changes here are intended to reflect whats in the project. Please confirm that the project is ok with these mods and if so, please send a PR.

These have long ago disappeared from OpenDaylight.

along with posting the latest YANG modules, would be welcome.

#556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants