[pull] main from protocolbuffers:main #227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
PiperOrigin-RevId: 694231283
…y shares the same implementation as the existing unknown fields API. PiperOrigin-RevId: 694241076
PiperOrigin-RevId: 694247011
PiperOrigin-RevId: 694253834
PiperOrigin-RevId: 694267002
…elds.
Adds test coverage for invalid empty strings (e.g. ""), non-numeric strings (e.g. "abc"), and partially-numeric strings (e.g. "12abc"), as well as valid exponential numeric strings ("1e5)
We will target enforcing non-conformant cases that should have failed to parse but didn't in upb in v30.x (our ~annual breaking release in some languages). Conformance failures to accept input we previously failed on can be landed at any time.
PiperOrigin-RevId: 694269337
PiperOrigin-RevId: 694275919
PiperOrigin-RevId: 694287000
Java and Python/C++ are both non-conformant, since they allow these invalid payloads. PiperOrigin-RevId: 694312115
PiperOrigin-RevId: 694345563
PiperOrigin-RevId: 694455435
PiperOrigin-RevId: 694462703
PiperOrigin-RevId: 694479808
Uses UTF8Encoding configured with throwOnInvalidBytes=True instead of default Encoding.UTF8 per https://stackoverflow.com/questions/62762770/forcing-encoding-utf8-getstring-to-throw-an-argumentexception/62763077#62763077 This surfaces errors for bad UTF-8 earlier in C# for consistency across languages as announced in https://protobuf.dev/news/2024-10-02/#utf-8-enforcement PiperOrigin-RevId: 694491987
PiperOrigin-RevId: 694492988
PiperOrigin-RevId: 696922501
…s in port.h. This reduces the cost of port_def.inc includes. PiperOrigin-RevId: 696931317
…ded with 64 bit sign extension, and thus can only take up 5 bytes. PiperOrigin-RevId: 696932804
PiperOrigin-RevId: 696936254
…_message' PiperOrigin-RevId: 696936553
PiperOrigin-RevId: 696942733
This is similar in effect to if GOOGLE_PROTOBUF_NO_RDTSC define was enabled always. Hashing the address of the table plus the per-process entropy added by absl::Hash is sufficient amount of entropy for this usecase. PiperOrigin-RevId: 696982713
PiperOrigin-RevId: 696997301
PiperOrigin-RevId: 697007124
…iasing PiperOrigin-RevId: 697008785
PiperOrigin-RevId: 697017028
PiperOrigin-RevId: 697036283
PiperOrigin-RevId: 697044521
PiperOrigin-RevId: 697065983
PiperOrigin-RevId: 697085100
PiperOrigin-RevId: 697200309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )