Add definitions for GetActiveAlarmInfo service
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavanderhoorn
commented
Oct 10, 2023
gavanderhoorn
force-pushed
the
get_active_alarm_info_srv
branch
from
0c7f4fc
to
4cf3147
Compare
gavanderhoorn
force-pushed
the
get_active_alarm_info_srv
branch
from
4cf3147
to
6b4a1ae
Compare
|
@ted-miller: I've pushed an updated version of the message and service definition(s). Based on our discussions, I believe this would be a good first version of the envisioned functionality. Not all fields will be populated by the initial implementation of the |
gavanderhoorn
commented
Oct 19, 2023
| # This stamp will not be corrected for Host PC <-> Yaskawa controller clock | ||
| # drift, as it is intended purely for informational purposes (ie: for humans) | ||
| # at this time. | ||
| builtin_interfaces/Time datetime |
There was a problem hiding this comment.
This is basically a UNIX epoch, but with nanosecond precision.
None of the (M+) APIs provide us with this directly, but we should be able to retrieve that info with some more work.
I want(ed) to already add the field, to avoid having to change the message definition later.
ted-miller
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.
This is a bit of a WIP, as I'm not completely sure about the contents of the
AlarmInfomessages.But I wanted to open this PR to facilitate discussion.