[WIP] Optimize Bukkit's MapPalette #308
Conversation
Up to nothing
we've got it to render using binarySearch but its not ideal and it has the same speed as without it....
…o patch-mappalette
… into patch-mappalette
|
I have a few questions: |
my tests prove a decrease of 38ms from the original code to that code. we're currently working on resolving the remaining problems with the color comparisons.
plugin drawing custom stuff on a map.
matches colors from a picture to the nearest ones that minecraft allows on maps. used when a plugin wants to draw an image to get the nearest colors of every pixel. |
|
@MrIvanPlays Thanks for the info! |
metabrixkt
changed the title
…o patch-mappalette
… into patch-mappalette
…o patch-mappalette
fixed build but wasn't able to fix the colors problem :/ looks like the problem is not the color comparison code anymore, but the way doubleColors is initialized it works for MapTest but doesn't want to work properly for that array :/
…o patch-mappalette
color lighting still isn't right. I've returned the getDistance calls to the double one, as it is more acruate. there is some improvement from changing the getDistance calls tho.
MrIvanPlays
changed the title
MrIvanPlays
changed the title
…o patch-mappalette
…o patch-mappalette
MrIvanPlays
force-pushed
the
ver/1.16.5
branch
2 times, most recently
from
c232045
to
ecf1662
Compare
duplexsystem
force-pushed
the
ver/1.16.5
branch
from
656de35
to
372911f
Compare
Titaniumtown
force-pushed
the
staging/1.16.5
branch
from
25b910f
to
2c205e0
Compare
Titaniumtown
force-pushed
the
staging/1.16.5
branch
from
4fcba35
to
f438550
Compare
|
I'm going to open new PR for this optimisation soon. |
Optimization for MapPalette, heavily optimized rewrite of
getDistance(Color c1, Color c2),matchColor(Color color)methods and others a bit.Don't merge until it's tested well and no issues found.
Reopening because of changed branch.