Skip to content
This repository has been archived by the owner on Jun 19, 2021. It is now read-only.

Allow "[CI-SKIP]" to be case-insensitive #481

Open
wants to merge 2 commits into
base: ver/1.16.5
Choose a base branch
from

Conversation

Toffikk
Copy link
Collaborator

@Toffikk Toffikk commented May 5, 2021

should fix issues with [ci-skip] because it needed to be uppercase but wasn’t most of the time in commit messages

Copy link

@Kylepoops Kylepoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use
.*\\[(ci-skip|CI-SKIP)\\].*
so that both of them work

@duplexsystem
Copy link
Collaborator

You should just be able to append /i so everything (like Ci-SkIp) works

@josephworks
Copy link

Yeah, I like uppercase CI-SKIP cause it means that the commit doesn't need to be built ( readme updates, etc..)

@Titaniumtown Titaniumtown changed the title make ci-skip lowercase Allow "[CI-SKIP]" to be case-insensitive May 13, 2021
@Titaniumtown
Copy link
Collaborator

You should just be able to append /i so everything (like Ci-SkIp) works

How would we do that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants