Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#58 Contributor showcase not showing #60

Merged
merged 5 commits into from
May 24, 2024
Merged

Conversation

Vaishalic288
Copy link
Contributor

@Vaishalic288 Vaishalic288 commented May 23, 2024

Related Issue

[#58 ]

Description

[Added Contributor list in Contributor showcase]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[
Screenshot from 2024-05-23 16-44-27
Screenshot from 2024-05-23 16-45-56

]

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[I have generated the code snippet from contrib.rocks and added to the Readme.md file]

Added contributor showcase
Removed default link added to contributors image
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@Vaishalic288 Vaishalic288 changed the title PR for issue #58 #58 Contributor showcase not showing May 23, 2024
@Vaishalic288 Vaishalic288 marked this pull request as draft May 23, 2024 09:27
@Vaishalic288 Vaishalic288 reopened this May 23, 2024
@Vaishalic288
Copy link
Contributor Author

I am not able to add labels to this PR. could you please help to do this as it seems I don't have permission to add labels ?

@Vaishalic288 Vaishalic288 marked this pull request as ready for review May 23, 2024 09:35
@Yeasir0032
Copy link
Owner

Could you please add the screenshot of the readme So that I can check it is working

@Vaishalic288 Vaishalic288 marked this pull request as draft May 23, 2024 11:17
@Vaishalic288
Copy link
Contributor Author

I have updated the code and attached the screenshot of Readme.md file.

@Vaishalic288 Vaishalic288 marked this pull request as ready for review May 23, 2024 12:20
@Yeasir0032 Yeasir0032 merged commit ac4996f into Yeasir0032:main May 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants