Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores CryptographyDeprecationWarning #901

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

bobokun
Copy link
Member

@bobokun bobokun commented Mar 9, 2023

We're seeing these warnings happen when running tronctl after upgrading twisted. This is due to twisted upstream library and is safe to ignore. Ideally we can remove this workaround once it's removed in twisted.

❯ tronctl -h
/opt/venvs/tron/lib/python3.8/site-packages/twisted/conch/ssh/transport.py:97: CryptographyDeprecationWarning: Blowfish has been deprecated
  b”blowfish-cbc”: (algorithms.Blowfish, 16, modes.CBC),
/opt/venvs/tron/lib/python3.8/site-packages/twisted/conch/ssh/transport.py:101: CryptographyDeprecationWarning: CAST5 has been deprecated
  b”cast128-cbc”: (algorithms.CAST5, 16, modes.CBC),
/opt/venvs/tron/lib/python3.8/site-packages/twisted/conch/ssh/transport.py:106: CryptographyDeprecationWarning: Blowfish has been deprecated
  b”blowfish-ctr”: (algorithms.Blowfish, 16, modes.CTR),
/opt/venvs/tron/lib/python3.8/site-packages/twisted/conch/ssh/transport.py:107: CryptographyDeprecationWarning: CAST5 has been deprecated
  b”cast128-ctr”: (algorithms.CAST5, 16, modes.CTR),
usage: tronctl [-h] [--version] [-v] [--server SERVER] [--cluster_name CLUSTER_NAME] [-s]
               {start,rerun,retry,recover,cancel,backfill,disable,enable,fail,success,skip,skip-and-publish,stop,kill,move,publish,discard,version} ...

Copy link
Member

@nemacysts nemacysts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming that the requirements files are correct - i have some suggestions for rewording/adding comments, but they're not necessarily blocking

tron/ssh.py Show resolved Hide resolved
tron/ssh.py Show resolved Hide resolved
tron/ssh.py Outdated Show resolved Hide resolved
@bobokun bobokun requested a review from nemacysts March 9, 2023 17:34
@bobokun bobokun merged commit c1314a0 into master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants