Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daylight Savings Time Bug #64

Closed
kentwills opened this issue Mar 14, 2017 · 1 comment · Fixed by #110
Closed

Daylight Savings Time Bug #64

kentwills opened this issue Mar 14, 2017 · 1 comment · Fixed by #110
Assignees

Comments

@kentwills
Copy link
Contributor

kentwills commented Mar 14, 2017

We try to provide some support for other timezones. Timezones need to be supported in both location and in time. For instance, certain times of the year SF is in PST and in other times it is in PDT. When calculating a meeting spec from a meeting subscription, this calculation is incorrect if it is done across timezones. pytest tests/logic/meeting_spec_test.py::test_get_meeting_datetime hits this bug and is failing on master.

kentwills added a commit to kentwills/beans that referenced this issue Mar 14, 2017
kentwills added a commit that referenced this issue Mar 14, 2017
@ipwnponies
Copy link
Contributor

We've discussed this issue offline, going to document it here.

The issue is in get_meeting_datetime implementation. It gets the meeting subscription's utc time and converts to the meeting's local time. This is incorrect because it will DST can change the timezone's offset from UTC. The fix would be to get the local time component of the meeting subscription, and create new local datetime for the current week that sets the time component.

You'll need to store meeting subscription datetime as a UTC timestamp, as this will allow you to determine the local time unambiguously (was it PDT or PST at that location at that time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants