Fido 3.0.0 - EventualResult instead of concurrent futures - Fix requests unicode bug #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FidoFutureAdapter
| performing the request, whether it is synchronous or actually asynchornous. | ||
|
|
||
| This adapter must be implemented by all bravado clients such as FidoClient | ||
| or RequestsClient to wrap the object returned by their 'request' method. |
There was a problem hiding this comment.
I don't see request clients using it though
|
I just uploaded fido==3.0.0 to https://pypi.python.org/pypi/fido |
|
lg2m |
| @@ -137,7 +138,8 @@ def request(self, request_params, operation=None, response_callbacks=None, | |||
| requests_future = RequestsFutureAdapter( | |||
| self.session, | |||
| self.authenticated_request(sanitized_params), | |||
| misc_options) | |||
| misc_options | |||
There was a problem hiding this comment.
trailing commas ? Or keep the style, that's what you do in tests as well
There was a problem hiding this comment.
keeping the style - amended
|
lg2m, just a formating nitpick |
lucagiovagnoli
force-pushed
the
fido-3.0.0
branch
from
8ad9d66
to
3fd8768
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade bravado to use fido 3.0.0
This change makes bravado capable of handling EventualResult objects which are now returned by Fido instead of a concurrent.futures.
I acted on our FutureAdaptor layer of abstraction by creating FidoFutureAdapter and making it and RequestFutureAdapter 'implement' FutureAdapter.
Requests bug
I also introduced a minor little workaround caused by a bug in 'requests' version < 2.8.1 which is documented in their changelog at https://pypi.python.org/pypi/requests
Tests
Testing might be broken on github until fido gets updated to 3.0.0 in https://pypi.python.org/simple/fido/
I manually tested with fido 3.0.0 and our internal acceptance suite though and it was all green.