Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the XML file format in the keyword detector (and maybe other plugins?) #270

Open
OiCMudkips opened this issue Nov 21, 2019 · 0 comments
Open

Support the XML file format in the keyword detector (and maybe other plugins?) #270

OiCMudkips opened this issue Nov 21, 2019 · 0 comments
Labels
bug The issue describes a malfunctioning aspect of the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. triaged The issue has been reviewed but has not been solved yet.

Comments

@OiCMudkips
Copy link
Contributor

OiCMudkips commented Nov 21, 2019 •
edited
Loading

In Yelp/detect-secrets-server#40 we got a report that a password in an XML tag called "password" was not detected. We can consider adding a regex to the keyword detector to detect values in such tags.

I'm a bit dubious as to whether this is a good idea since XML tags and inner values often spans multiple lines (hence the nice-to-have tag), but I figure I'd open up the issue for discussion.
@OiCMudkips OiCMudkips changed the title Support the XML file format Support the XML file format in the keyword detector (and maybe other plugins?) Nov 21, 2019
@OiCMudkips OiCMudkips mentioned this issue Nov 21, 2019
Closed
@pablosnt pablosnt mentioned this issue Jan 28, 2021
Closed
@lorenzodb1 lorenzodb1 added pending The issue still needs to be reviewed by one of the maintainers. and removed accuracy labels Jun 13, 2022
@lorenzodb1 lorenzodb1 added help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. bug The issue describes a malfunctioning aspect of the project. triaged The issue has been reviewed but has not been solved yet. and removed pending The issue still needs to be reviewed by one of the maintainers. labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue describes a malfunctioning aspect of the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. triaged The issue has been reviewed but has not been solved yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OiCMudkips @lorenzodb1