Remove v1 style nodes #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmb
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
I think this should be okay. Definitely synapse is reading from the /smartstack/ paths and so if meshd/envoy is too then I think we are safe. I did find one reference to /nerve/ in some cassandra puppet code so we should just confirm that isn't a problem. Otherwise gfi, but yes please carefully. I'd recommend trying in one stage first (that's why we have two so nbd if we break one!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #25 with merge conflicts resolved.
Can this be merged now? I couldn't find anything that uses the v1 style nodes. This will help zookeeper from being overloaded when services are also registered through Envoy (see CORESERV-8573).