Add pgctl environ to log pipeline #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
0xngold
reviewed
Feb 21, 2017
| @@ -871,3 +872,42 @@ def it_runs_after_all_services_have_stopped(self): | |||
| 0, | |||
| norm=norm.pgctl, | |||
| ) | |||
|
|
|||
|
|
|||
| class DescribePGCTLEnvironment(object): | |||
There was a problem hiding this comment.
Nit: uppercasing pgctl feels a little odd.
| @@ -176,19 +176,20 @@ def svstat_parse(svstat_string): | |||
| return SvStat(state, pid, exitcode, seconds, process) | |||
|
|
|||
|
|
|||
| def prepend_timestamps_to(logfile): | |||
| def prepend_timestamps_to(logfile, env=None): | |||
| return timestamps.stdin | ||
|
|
||
|
|
||
| def _pipeline(cmd, stdin, stdout): | ||
| def _pipeline(cmd, stdin, stdout, env=None): |
| ) | ||
| assert returncode == 0 | ||
| assert stderr == '' | ||
| for pid in stdout.split('\n'): |
There was a problem hiding this comment.
What happens if lsof returns nothing?
|
After talking to bukzor in person, we will put a hold on this PR. We are able to resolve our issue in another (& better) solution. We will come back to this in the future if needs arise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PGCTL_* environment variables to processes spun up by pgctl. This makes it easier for process management.