set response status codes for unhandled exceptions

tests/conftest.py

@@ -1,9 +1,9 @@
 from unittest import mock
 
 import pytest
+from pyramid.request import Request
 
 from pyramid_zipkin import request_helper
-from pyramid.request import Request
 
 
 @pytest.fixture
@@ -15,6 +15,7 @@ def dummy_request():
     request.path = 'bla'
     return request
 
+
 @pytest.fixture
 def get_request():
     request = Request.blank('GET /sample')
@@ -24,6 +25,7 @@ def get_request():
     request.unique_request_id = '17133d482ba4f605'
     return request
 
+
 @pytest.fixture
 def dummy_response():
     response = mock.Mock()

tests/tween_test.py

@@ -79,6 +79,7 @@ def test_zipkin_tween_post_handler_hook(
             mock_span.return_value.__enter__.return_value,
         )
 
+
 @pytest.mark.parametrize(['set_callback', 'called'], [(False, 0), (True, 1)])
 @pytest.mark.parametrize('is_tracing', [True])
 def test_zipkin_tween_exception(
@@ -89,7 +90,7 @@ def test_zipkin_tween_exception(
     called,
 ):
     """
-    If request processing throws an exception verify response_status_code = 500 is being set
+    If request processing has an exception set response_status_code to 500
     """
 
     mock_post_handler_hook = mock.Mock()
@@ -107,8 +108,8 @@ def test_zipkin_tween_exception(
 
     try:
         tween.zipkin_tween(handler, dummy_response)(get_request)
-        pytest.fail('exception was expected to be thrown')
-    except Exception as e:
+        pytest.fail('exception was expected to be thrown!')
+    except:
         pass
 
     spans = transport.get_payloads()
@@ -147,7 +148,6 @@ def test_zipkin_tween_no_exception(
     spans = transport.get_payloads()
     assert len(spans) == 1
     span = json.loads(spans[0])[0]
-    span = decoded_spans[0]
     span['tags']['response_status_code'] = '200'
 
     assert handler.call_count == 1