-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump io.swagger:swagger-codegen from 2.3.1 to 2.4.12 #91
Merged
macisamuele
merged 5 commits into
Yelp:master
from
macisamuele:maci-bump-swagger-codegen-2
Feb 4, 2020
Merged
Bump io.swagger:swagger-codegen from 2.3.1 to 2.4.12 #91
macisamuele
merged 5 commits into
Yelp:master
from
macisamuele:maci-bump-swagger-codegen-2
Feb 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom InlineModelResolver is no longer needed as upstream project fixed it in swagger-api/swagger-codegen#9765 and released with version https://github.com/swagger-api/swagger-codegen/releases/tag/v2.4.9
…fined according to the following order: x-model, title, codegen provided
macisamuele
force-pushed
the
maci-bump-swagger-codegen-2
branch
from
February 4, 2020 19:44
1855348
to
26cfafe
Compare
cortinico
reviewed
Feb 4, 2020
@@ -1,13 +1,13 @@ | |||
package com.yelp.codegen | |||
|
|||
import com.yelp.codegen.utils.InlineModelResolver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:O
cortinico
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Also we're finally a 100% Kotlin Project!
cortinico
added
enhancement
New feature or request
and removed
infra
PR or Issue related to project infrastructure
labels
Feb 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does nothing more than bumping the
swagger-codegen
dependency.There are no specific changes in the new version that makes the tool better as well as the generated code (in our samples) has no changes if we're using the old or new version.
The bump is still recommended as
generateSwagger
gradle task might be used to gate in templates available onswagger-codegen
and bumping the library would allow this use-case to get updated templates.An example of generating python code might look like